Great tips! Since I just started blogging in January I am still really just getting my toes wet in affiliates. However, I did notice that pictures and real life demonstrations of the product really help. For instance, I have several food posts where I talk about my favorite cook books and show what I have cooked out of them, and then included amazon links, sure enough I sold a few cook books.
If you have pop-ups and optins on every page, I would have to think that it would be a lot harder to convince someone to link to it. Especially since the pages where you have your optins (and probably receive the most traffic) are probably the same pages that you have your best content on as well that you'd be hoping to pitch in your outreach campaign.