On one hand, long and ugly affiliate tracking links are a straight giveaway to people that you want to sell them a product (and people may be uncomfortable clicking on them). Therefore, making your link shorter and "nicer" looking will it give a more professional appearance. One of my favorite plugins for making links look "pretty" is the Pretty Links WordPress plugin.
A popular tactic to make money on social media is to pay for advertising affiliate products. Create ads for particular affiliate products that are big sellers and have a high yield. Then target these ads at specific custom audiences to ensure your ads are viewed by those who will have an interest in the product you are promoting. If viewers click through your from advert to the product page and make a purchase then you will earn an affiliate fee.
There are numerous printing companies that will print your designs onto not just T-shirts, but also hoodies, hats, posters, cushions, bags, and phone cases, to name a few items. These businesses also offer fulfillment services. This means that you promote the merchandise on your own site and once you sell a product the printing company will not only print your design but also send the item directly to the buyer. So all you have to do is concentrate on the marketing and selling of your products, and the fulfillment company will take care of the rest.
Be professional. When you submit a résumé, don’t type it in ALL CAPS and please don’t avoid the caps lock like the plague. Know how to use it without looking incompetent. Write in complete sentences with proper grammar. Of course, there will be exceptions, but even with the exceptions, you must keep it professional. You’re building their view of you.
If you have pop-ups and optins on every page, I would have to think that it would be a lot harder to convince someone to link to it. Especially since the pages where you have your optins (and probably receive the most traffic) are probably the same pages that you have your best content on as well that you'd be hoping to pitch in your outreach campaign.